| Conditions | 4 |
| Total Lines | 54 |
| Code Lines | 43 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | import { Inject } from '@nestjs/common'; |
||
| 23 | |||
| 24 | public async execute(command: CreateNotificationCommand): Promise<string> { |
||
| 25 | const { message, type, leaveReaquest } = command; |
||
| 26 | |||
| 27 | if (type === NotificationType.POST) { |
||
| 28 | const { id } = await this.mattermostNotifier.createPost( |
||
| 29 | MATTERMOST_CHANNEL_LEAVES_ID, |
||
| 30 | message |
||
| 31 | ); |
||
| 32 | const notification = await this.notificationRepository.save( |
||
| 33 | new Notification(type, message, id, leaveReaquest) |
||
| 34 | ); |
||
| 35 | |||
| 36 | return notification.getId(); |
||
| 37 | } |
||
| 38 | |||
| 39 | if (type === NotificationType.REACTION) { |
||
| 40 | const post = await this.notificationRepository.findByLeaveRequestIdAndType( |
||
| 41 | leaveReaquest.getId(), |
||
| 42 | NotificationType.POST |
||
| 43 | ); |
||
| 44 | |||
| 45 | const { id } = await this.mattermostNotifier.createReaction( |
||
| 46 | post.getResourceId(), |
||
| 47 | message |
||
| 48 | ); |
||
| 49 | |||
| 50 | const notification = await this.notificationRepository.save( |
||
| 51 | new Notification(type, message, post.getResourceId(), leaveReaquest) |
||
| 52 | ); |
||
| 53 | |||
| 54 | return notification.getId(); |
||
| 55 | } |
||
| 56 | |||
| 57 | if (type === NotificationType.COMMENT) { |
||
| 58 | const post = await this.notificationRepository.findByLeaveRequestIdAndType( |
||
| 59 | leaveReaquest.getId(), |
||
| 60 | NotificationType.POST |
||
| 61 | ); |
||
| 62 | |||
| 63 | const { id } = await this.mattermostNotifier.createComment( |
||
| 64 | this.configService.get<string>('MATTERMOST_CHANNEL_LEAVES_ID'), |
||
| 65 | message, |
||
| 66 | post.getResourceId() |
||
| 67 | ); |
||
| 68 | |||
| 69 | const notification = await this.notificationRepository.save( |
||
| 70 | new Notification(type, message, id, leaveReaquest) |
||
| 71 | ); |
||
| 72 | |||
| 73 | return notification.getId(); |
||
| 74 | } |
||
| 75 | |||
| 76 | throw new Error('Type not managed'); |
||
| 77 | } |
||
| 79 |